fix: expose __queryClient only in dev, un-double-format TVL, type-check tests, seed farm e2e via network (#471, #472, #473, #475) by SweetBoy-eth · Pull Request #503 · SmartDropLabs/smartdrop-frontend

SweetBoy-eth · 2026-09-25T05:00:56Z

Summary

Four fixes across E2E hygiene, stats rendering, and TypeScript coverage.

closes #474 — Never expose `window.__queryClient` in production

ContextProvider now assigns window.__queryClient only when
process.env.NODE_ENV !== 'production'. The QueryClient is no longer
leaked in production bundles (previously gated only on
NEXT_PUBLIC_E2E). Dev-server E2E (lock-unlock-lifecycle) keeps
working since pnpm dev runs with NODE_ENV=development.

closes #476 — Stop double-formatting Total Value Locked

getPlatformStats() already returns totalValueLocked as a localized
currency string ("$3,500"). PlatformStats was piping that through
formatCredits, rendering $0.0M XLM. The TVL stat now renders
stats.tvl directly; formatCredits remains in use for the credit
velocity stat (raw credit units).

Updated test mock (tvl: '$3,500', raw credit-velocity number)
Regenerated PlatformStats snapshot

closes #477 — Type-check test files

Removed **/*.test.ts(x) from tsconfig.json exclude so tests are
covered by pnpm typecheck (configs and e2e/**, tests/** stay
excluded). Fixed every error this surfaced:

loading.tsx: widen SkeletonBar.w to accept responsive objects
Navbar.tsx: add missing useEffect import
useLockFlow.ts: remove duplicate stepRef declaration
farmStore.ts: export FarmStore type for selector typing
Typed wallet/toast/mocks across BoostModal, UnlockModal, useLeaderboard,
useSorobanEvents, useSorobanQuery, validateEnv tests
Buffer.alloc instead of new Uint8Array().fill() for StrKey seeds
(feeBumpGuard, soroban, feebump, history tests)
Cast auth fixtures and process.env where strict types required it

closes #475 — Seed `farm.spec.ts` at the network layer

Rewrote e2e/farm.spec.ts to remove all window.__queryClient
dependency (per issue). Pool and position data are now seeded by
mocking the Soroban RPC HTTP layer:

simulateTransaction returns pre-computed XDR for get_pools /
get_user_position, function-specific auth for lock/unlock
sendTransaction flips a stateful empty ⇄ locked position so the
post-mutation QueryClient invalidation refetches updated data
getLatestLedger intentionally omits headerXdr/metadataXdr so
velocity/events polling fails closed without hitting the real network
locked_at fixture uses epoch ms to match FarmPosition
(unlockAvailableAt = lockedAt + lockPeriodSeconds * 1000)
e2e/playwright.config.ts sets NEXT_PUBLIC_FACTORY_CONTRACT_ID and
NEXT_PUBLIC_SIMULATION_ACCOUNT in webServer.env so
getFactoryPools / simulation calls resolve under the dev server

Verification

npx tsc --noEmit → 0 errors (was 9 pre-existing + all newly
surfaced test-file errors)
13 changed unit-test suites → 96/96 passing
playwright e2e/farm.spec.ts → 5/5 passing (connect, deposit,
countdown, fast-forward unlock, unlock submit)
playwright --list → 15 tests / 6 files, no collection errors
Remaining suite failures (useLeaderboard race, useSorobanEvents
retention) fail identically on baseline main

…uction Never leak the QueryClient in a production bundle; dev-only check keeps pnpm dev e2e (lock-unlock-lifecycle) working without NEXT_PUBLIC_E2E.

…double-format getPlatformStats already returns totalValueLocked as a localized currency string (e.g. $3,500); formatCredits turned it into $0.0M XLM.

…/ credit velocity

…500.0M XLM)

Drop **/*.test.{ts,tsx} from tsconfig exclude so test files are type-checked; keep vitest/playwright configs and tests/**, e2e/**.

… object

…ckFlow

…, mutation cast)

…ockAssets mocks

…derboard tests

… mocks

…mock typing

…Guard tests

…uth tests

… tests

…twork-guard tests

… tests

…ver env Set NEXT_PUBLIC_FACTORY_CONTRACT_ID and NEXT_PUBLIC_SIMULATION_ACCOUNT so getFactoryPools succeeds under the Playwright dev server.

…ueryClient Mock soroban-testnet RPC (get_pools/get_user_position XDR, sendTransaction flips position state) instead of injecting into window.__queryClient; stateful lock/unlock flows with fixed clock for countdown tests.

…ixture FarmPosition.lockedAt is ms (unlockAvailableAt = lockedAt + lockPeriodSeconds*1000); seconds values rendered 'Unlocked' instantly.

netlify · 2026-09-25T05:01:02Z

❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.

Name	Link
🔨 Latest commit	`d166ed8`
🔍 Latest deploy log	https://app.netlify.com/projects/spiffy-melomakarona-eb1e8a/deploys/6ab60074d7716b0008c86494

netlify · 2026-09-25T05:01:14Z

❌ Deploy Preview for smart-drop failed.

Name	Link
🔨 Latest commit	`d166ed8`
🔍 Latest deploy log	https://app.netlify.com/projects/smart-drop/deploys/6ab600745d286400089735dc

drips-wave · 2026-09-25T05:02:46Z

@SweetBoy-eth Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

TheCodingChef-eth added 24 commits September 24, 2026 17:50

fix(SmartDropLabs#471): expose window.__queryClient only outside prod…

981ab1f

…uction Never leak the QueryClient in a production bundle; dev-only check keeps pnpm dev e2e (lock-unlock-lifecycle) working without NEXT_PUBLIC_E2E.

fix(SmartDropLabs#472): render tvl directly instead of formatCredits …

4fa8506

…double-format getPlatformStats already returns totalValueLocked as a localized currency string (e.g. $3,500); formatCredits turned it into $0.0M XLM.

test(SmartDropLabs#472): align PlatformStats mock with formatted tvl …

076c44c

…/ credit velocity

test(SmartDropLabs#472): regenerate PlatformStats snapshot ($3,500, 8…

0f02e38

…500.0M XLM)

fix(SmartDropLabs#473): stop excluding tests from tsc type-checking

c1028ba

Drop **/*.test.{ts,tsx} from tsconfig exclude so test files are type-checked; keep vitest/playwright configs and tests/**, e2e/**.

fix(SmartDropLabs#473): widen SkeletonBar w prop to accept responsive…

14c7962

… object

fix(SmartDropLabs#473): import useEffect in Navbar (missing from import)

2116f89

fix(SmartDropLabs#473): remove duplicate stepRef declaration in useLo…

7471281

…ckFlow

fix(SmartDropLabs#473): export FarmStore type from farmStore for tests

ab3e847

test(SmartDropLabs#473): type BoostModal wallet mock (signTransaction…

18f3995

…, mutation cast)

test(SmartDropLabs#473): type UnlockModal FarmStore selectors and unl…

f75e271

…ockAssets mocks

test(SmartDropLabs#473): cast process.env in validateEnv tests

daf3725

test(SmartDropLabs#473): type fetchLeaderboardMock as vi.fn in useLea…

7f584be

…derboard tests

test(SmartDropLabs#473): add beforeEach import and typed wallet/toast…

8c1191c

… mocks

test(SmartDropLabs#473): add networkName/isNetworkMismatch and toast …

ac88a69

…mock typing

test(SmartDropLabs#473): use Buffer.alloc for StrKey seeds in feeBump…

59dbf9f

…Guard tests

test(SmartDropLabs#473): cast SorobanAuthorizationEntry fixtures in a…

a71b75d

…uth tests

test(SmartDropLabs#473): use Buffer.alloc for StrKey seeds in feebump…

fa6e5cf

… tests

test(SmartDropLabs#473): use Buffer.alloc for StrKey seeds in history…

cf85041

… tests

test(SmartDropLabs#473): destructure rpcServer from makeService in ne…

f0a0f6c

…twork-guard tests

test(SmartDropLabs#473): use Buffer.alloc for StrKey seeds in soroban…

630214d

… tests

test(SmartDropLabs#475): seed factory + simulation account via webSer…

48dd67a

…ver env Set NEXT_PUBLIC_FACTORY_CONTRACT_ID and NEXT_PUBLIC_SIMULATION_ACCOUNT so getFactoryPools succeeds under the Playwright dev server.

fix(SmartDropLabs#475): store locked_at in epoch ms in POSITION_XDR f…

d7cae34

…ixture FarmPosition.lockedAt is ms (unlockAvailableAt = lockedAt + lockPeriodSeconds*1000); seconds values rendered 'Unlocked' instantly.

Merge branch 'main' into fix/issues-471-472-473-475

d166ed8

ritaifeoluwa merged commit e6cd18f into SmartDropLabs:main Sep 25, 2026
0 of 8 checks passed

Navigation Menu

fix: expose __queryClient only in dev, un-double-format TVL, type-check tests, seed farm e2e via network (#471, #472, #473, #475) - #503

fix: expose __queryClient only in dev, un-double-format TVL, type-check tests, seed farm e2e via network (#471, #472, #473, #475)#503
ritaifeoluwa merged 25 commits into
SmartDropLabs:mainfrom
SweetBoy-eth:fix/issues-471-472-473-475

SweetBoy-eth commented Sep 25, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

drips-wave Bot commented Sep 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

SweetBoy-eth commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

closes #474 — Never expose window.__queryClient in production

closes #476 — Stop double-formatting Total Value Locked

closes #477 — Type-check test files

closes #475 — Seed farm.spec.ts at the network layer

Verification

Uh oh!

netlify Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.

Uh oh!

netlify Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for smart-drop failed.

Uh oh!

drips-wave Bot commented Sep 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SweetBoy-eth commented Sep 25, 2026 •

edited

Loading

closes #474 — Never expose `window.__queryClient` in production

closes #475 — Seed `farm.spec.ts` at the network layer

netlify Bot commented Sep 25, 2026 •

edited

Loading

netlify Bot commented Sep 25, 2026 •

edited

Loading